Skip to content

feat(clients): make endpoints resolution modular #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from

Conversation

trivikr
Copy link
Owner

@trivikr trivikr commented Aug 23, 2021

Issue

Internal JS-2773
Refs for PoC PR: aws#2696

This PR will be posted upstream, after aws#2701 is merged

Description

Makes endpoint resolution modular as follows:

Testing

Integration tests are succesful:

$ yarn test:integration
 PASS  clients/client-transcribe-streaming/test/index.integ.spec.ts (31.631 s)
  TranscribeStream client
    ✓ should stream the transcript (28799 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        32.11 s
Ran all test suites.
Done in 32.76s.

$ yarn test:integration-legacy 
yarn run v1.22.11
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m35.810s
Done in 99.40s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft August 23, 2021 18:34
@trivikr trivikr force-pushed the getRegionInfo-dev branch from c335c69 to fe4ad53 Compare August 23, 2021 19:35
@trivikr trivikr force-pushed the clients-getRegionInfo-dev branch 3 times, most recently from b258c50 to a945915 Compare August 23, 2021 21:28
@trivikr trivikr changed the title [WIP] feat(clients): make endpoints resolution modular feat(clients): make endpoints resolution modular Aug 23, 2021
@trivikr

This comment has been minimized.

@trivikr trivikr force-pushed the clients-getRegionInfo-dev branch 2 times, most recently from 4d0807e to d739618 Compare August 24, 2021 02:40
@trivikr
Copy link
Owner Author

trivikr commented Aug 24, 2021

PR posted upstream at aws#2704

@trivikr trivikr closed this Aug 24, 2021
@trivikr trivikr deleted the clients-getRegionInfo-dev branch August 24, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant