Skip to content

FAI-882: Add kwargs to explainers #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2022
Merged

FAI-882: Add kwargs to explainers #113

merged 2 commits into from
Nov 22, 2022

Conversation

RobGeada
Copy link
Collaborator

The benchmarks repo required the explainers to have kwargs; the SHAP and LIME now use kwargs for:

  • SHAP: everything but background, link_type
  • LIME: everything but samples

Docs are updated accordingly

@RobGeada RobGeada marked this pull request as ready for review November 21, 2022 14:28
Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobGeada LGTM, thanks.

As note for the future, we might want to type the **kwargs as a TypedDict with corresponding typing. This will allow for code completion when PEP692 is accepted (potentially Python 3.12).

Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobGeada RobGeada merged commit c165b1e into main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants