FAI-926: Implement custom counterfactual goal criteria #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAI-926
This PR adds programmable goal criteria to the Python counterfactuals.
Goal criteria allow to pass arbitrarily complex functions as a goal (using the CF proposal predictions as inputs) for scenarios where a static goal might not be sufficient.
The criteria can be any Python function and may take either Pandas dataframes or Numpy arrays as inputs and must return a tuple consisting of distance and score.
This PR also abstracts some functionality previously on the
Modelwrapper class to a more genericCallableWrapper, since the goal criteria shares some common functionality withModel.