FAI-849: Tyrus dashboard #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruivieira
requested changes
Nov 1, 2022
There was a problem hiding this comment.
LGTM, thanks @RobGeada!
Just a couple of comments:
- Is it possible to add the
bokehdependency topyproject.toml? - When running with
tyrus = Tyrus(..., notebook=True), both the inline and file visualisations are shown.
This only seems to happen when, in a notebook, first the file is generated and then the inline is generate in subsequent runs.
ruivieira
reviewed
Nov 1, 2022
RobGeada
added a commit
that referenced
this pull request
Nov 22, 2022
* tyrus dashboard and visualizations * linting and black * merge conflict fix * fixed typo in requirements * linting round 2 * linting round 3 * undid change to rename limeresults.map to limeresults.get_saliencies * fixed dual output bug, added bokeh to pyproject * linting * return plots either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the Tyrus bokeh visualizations + TrustyAI runner