add event and prekey function #777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
requested changes
Mar 21, 2025
connectionevents.go
Outdated
| @@ -39,7 +39,7 @@ func (cli *Client) handleStreamError(node *waBinary.Node) { | |||
| case code == "401" && conflictType == "device_removed": | |||
| cli.expectDisconnect() | |||
| cli.Log.Infof("Got device removed stream error, sending LoggedOut event and deleting session") | |||
| go cli.dispatchEvent(&events.LoggedOut{OnConnect: false, Reason: events.ConnectFailureLoggedOut}) | |||
| go cli.dispatchEvent(&events.LoggedOut{Jid: cli.Store.ID, OnConnect: false, Reason: events.ConnectFailureLoggedOut}) | |||
There was a problem hiding this comment.
These are unnecessary and won't be added, the user is expected to remember which client an event came from
keepalive.go
Outdated
| go cli.dispatchEvent(&events.KeepAliveSuccess{ | ||
| Jid: cli.Store.ID, | ||
| LastSuccess: lastSuccess, | ||
| }) |
There was a problem hiding this comment.
What's the point of this? There are already events for keepalive failing and restoring
prekeys.go
Outdated
| return cli.fetchPreKeys(ctx, users) | ||
| } | ||
|
|
||
| func (cli *Client) FetchPreKeyTimes(ctx context.Context, users []types.JID) (map[types.JID]int64, error) { |
There was a problem hiding this comment.
And what's the point of this? The library handles prekeys internally, users don't need to care about them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prekeys: query the last time the public key was uploaded
prekeys: publicize the FetchPreKeys function
events: add keep alive success event
events: logout event adds current jid