Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport of support symbol as object key #23

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions build/stringifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function createStringifier (customOptions) {
return function stringifyAny (push, x) {
var context = this;
var handler = handlerFor(context.node, options, handlers);
var currentPath = '/' + context.path.join('/');
var currentPath = '/' + context.path.map(String).join('/');
var customization = handlers[currentPath];
var acc = {
context: context,
Expand Down Expand Up @@ -1435,7 +1435,11 @@ function decorateObject () {
}

function sanitizeKey (key) {
return /^[A-Za-z_]+$/.test(key) ? key : JSON.stringify(key);
if (typeof key === 'symbol') {
return key.toString();
} else {
return /^[A-Za-z_]+$/.test(key) ? key : JSON.stringify(key);
}
}

function afterAllChildren (context, push, options) {
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function createStringifier (customOptions) {
return function stringifyAny (push, x) {
var context = this;
var handler = handlerFor(context.node, options, handlers);
var currentPath = '/' + context.path.join('/');
var currentPath = '/' + context.path.map(String).join('/');
var customization = handlers[currentPath];
var acc = {
context: context,
Expand Down
6 changes: 5 additions & 1 deletion strategies.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,11 @@ function decorateObject () {
}

function sanitizeKey (key) {
return /^[A-Za-z_]+$/.test(key) ? key : JSON.stringify(key);
if (typeof key === 'symbol') {
return key.toString();
} else {
return /^[A-Za-z_]+$/.test(key) ? key : JSON.stringify(key);
}
}

function afterAllChildren (context, push, options) {
Expand Down