fix(plugin-serverless): handle direct username/password input

Previously if you'd call `twilio serverless:deploy` or similar commands with `--username` and
`--password` explicitly passed as API Key/Secret, it would both read the Service SID and write the
Service SID in the deployinfo cache for the Account SID that was associated with the default
profile. This change will ignore the default profile/client if username or password are passed.

BREAKING CHANGE: You have to use --username and --password effectively together if you use either

fix #261

Author: dkundel

packages/plugin-serverless/src/utils.js

@@ -69,6 +69,17 @@ function normalizeFlags(flags, aliasMap) {
 function createExternalCliOptions(flags, twilioClient) {
   const profile = flags.profile;
 
+  if (flags.username || flags.password) {
+    return {
+      username: flags.username,
+      password: flags.password,
+      accountSid: flags.username.startsWith('AC') ? flags.username : undefined,
+      profile: undefined,
+      logLevel: undefined,
+      outputFormat: undefined,
+    };
+  }
+
   return {
     username: twilioClient.username,
     password: twilioClient.password,