Skip to content

Deployment with --username and --password as API Key/Secret fails #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue May 13, 2021 · 0 comments · Fixed by #268
Closed

Deployment with --username and --password as API Key/Secret fails #261

dkundel opened this issue May 13, 2021 · 0 comments · Fixed by #268

Comments

@dkundel
Copy link
Contributor

dkundel commented May 13, 2021

If you deploy with --username and --password as API Key and API Secret it fails with a 404 where it grabs the wrong Service SID and tries to access /Environments.

regarding #255
dkundel added a commit that referenced this issue May 18, 2021
@dkundel
fix(plugin-serverless): handle direct username/password input
fcc3a87 
Previously if you'd call `twilio serverless:deploy` or similar commands with `--username` and
`--password` explicitly passed as API Key/Secret, it would both read the Service SID and write the
Service SID in the deployinfo cache for the Account SID that was associated with the default
profile. This change will ignore the default profile/client if username or password are passed.

BREAKING CHANGE: You have to use --username and --password effectively together if you use either

fix #261
@dkundel dkundel mentioned this issue May 18, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-serverless): handle direct username/password input twilio-labs/serverless-toolkit
1 participant
@dkundel