Skip to content

Flag aliases don't work in Twilio CLI #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue Apr 20, 2021 · 0 comments · Fixed by #267
Closed

Flag aliases don't work in Twilio CLI #242

dkundel opened this issue Apr 20, 2021 · 0 comments · Fixed by #267

Comments

@dkundel
Copy link
Contributor

dkundel commented Apr 20, 2021

The promote command accepts both source-environment and from as synonymous values. In yargs we can do this through alias definitions. It seems like oclif can't handle these. We should figure out an alternative.

I see two paths:

  1. we contribute this ability to oclif
  2. inside our yargs to oclif converter we add logic that double registers the arguments and then merges them back together.
dkundel added a commit that referenced this issue May 14, 2021
@dkundel
fix(plugin-serverless): add alias support
1e313df 
Previously only one character aliases worked since oclif doesn't support anything else. I ended up
adding steps to our normalization to "fake" alias support

fix #242
dkundel added a commit that referenced this issue May 14, 2021
@dkundel
fix(plugin-serverless): add alias support
8046412 
Previously only one character aliases worked since oclif doesn't support anything else. I ended up
adding steps to our normalization to "fake" alias support

fix #242
@dkundel dkundel mentioned this issue May 14, 2021
Merged
1 task
dkundel added a commit that referenced this issue May 17, 2021
@dkundel
fix(plugin-serverless): add alias support (#267)
de3cdb4 
Previously only one character aliases worked since oclif doesn't support anything else. I ended up
adding steps to our normalization to "fake" alias support

fix #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-serverless): add alias support twilio-labs/serverless-toolkit
1 participant
@dkundel