feat: extract runtime-handler and lazyLoading #252
Conversation
|
This PR will also officially drop Node 10 support |
| configureWatcher(config, server); | ||
| return server.getApp(); | ||
| } catch (err) { | ||
| debug( |
There was a problem hiding this comment.
Do we need to catch this if the version of twilio-run depends on runtime-handler? What is the situation in which this version of twilio-run would not have access to a LocalDevelopmentServer from this package, regardless of which version it is?
There was a problem hiding this comment.
And consequently, do we need to keep all the server code in twilio-run as well as in runtime-handler?
There was a problem hiding this comment.
it doesn't actually depend on runtime-handler. It's a devDependency for the type but the require comes from the customers project not bundled from twilio-run. We could do both but I feel like that might introduce more edge cases than just ripping the bandaid off in the next major release and dropping all the code.
|
The PR should be ready for review but shouldn't be merged yet which is why it's in progress |
dkundel
changed the title
This is still in progress. I still have to verify the functionality and port/add tests. As part of this change the new runtime-handler is now using the
twiliopackage that person has installed.In the past we were relying on the resolution of Node.js to pick up the right one but it might pick up the wrong one.
fixes: #250
Contributing to Twilio