fix(twilio-run): fix global scope in forked process #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were requiring the respective Function file before the global scope was created. If a user was referencing a global object such as `Runtime` outside of the `handler` function it would throw an UnhandledPromiseException because the Runtime wasn't constructe yet. This change only requires the Function right before execution. This will also create more acurate timing results for cold starts. During the fix I realized that the Function was also required twice, once by the Server and once by the forked process. The server should only require the Function if it's not a forked process.
childish-sambino
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were requiring the respective Function file before the global scope was created. If a user was
referencing a global object such as
Runtimeoutside of thehandlerfunction it would throw anUnhandledPromiseException because the Runtime wasn't constructed yet. This change only requires the
Function right before execution. This will also create more accurate timing results for cold starts.
During the fix I realized that the Function was also required twice, once by the Server and once by
the forked process. The server should only require the Function if it's not a forked process.
Contributing to Twilio