fix(plugin-serverless): handle direct username/password input #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you'd call `twilio serverless:deploy` or similar commands with `--username` and `--password` explicitly passed as API Key/Secret, it would both read the Service SID and write the Service SID in the deployinfo cache for the Account SID that was associated with the default profile. This change will ignore the default profile/client if username or password are passed. BREAKING CHANGE: You have to use --username and --password effectively together if you use either fix #261
ktalebian
reviewed
May 18, 2021
ktalebian
approved these changes
May 18, 2021
ktalebian
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you'd call
twilio serverless:deployor similar commands with--usernameand--passwordexplicitly passed as API Key/Secret, it would both read the Service SID and write theService SID in the deployinfo cache for the Account SID that was associated with the default
profile. This change will ignore the default profile/client if username or password are passed.
BREAKING CHANGE: You have to use --username and --password effectively together if you use either
fix #261
Contributing to Twilio