Skip to content

Add runtime-handler check to deploy step #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue May 21, 2021 · 0 comments · Fixed by #280
Closed

Add runtime-handler check to deploy step #273

dkundel opened this issue May 21, 2021 · 0 comments · Fixed by #280

Comments

@dkundel
Copy link
Contributor

dkundel commented May 21, 2021

Right now when you deploy and the @twilio/runtime-handler is set to a semver range we'll only fail when the API fails down the line. We should detect whether the version is a semver range and then never start the deployment in the first place.
dkundel added a commit that referenced this issue Jun 16, 2021
@dkundel
feat(twilio-run): add runtime-handler version checks
f142c98 
With this change we start validating the `@twilio/runtime-handler` version before deployment in
order to avoid failures during build time.

fix #273
@dkundel dkundel mentioned this issue Jun 16, 2021
Merged
1 task
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(twilio-run): add runtime-handler version checks twilio-labs/serverless-toolkit
1 participant
@dkundel