Skip to content

feat(logs): adds command to access new logging functions #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 18, 2020

Conversation

philnash
Copy link
Contributor

Initial attempt to add logs to twilio-run.

Much like the PR in serverless-api this doesn't cover all the filters available for the logs endpoint. It is a first attempt and could do with a review.

It adds the logs command.

npx twilio-run logs --tail

The above command will pick up the project config and stream the logs from the functions in the service and environment (dev by default).

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel February 11, 2020 05:56
@philnash philnash requested a review from dkundel March 16, 2020 01:05
@philnash
Copy link
Contributor Author

Travis CI seems to be having issues with installing/running Node 10. @dkundel Can you nudge Travis and kick the build off again to make it pass please.

Copy link
Contributor

@dkundel dkundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional comments but I think we are very close to shipping this :)

@philnash philnash requested a review from dkundel March 17, 2020 01:03
@philnash
Copy link
Contributor Author

I believe this to be complete now. My concerns about not showing logs were unfounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants