Skip to content

feat: add better system env support #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

dkundel
Copy link
Contributor

@dkundel dkundel commented Jun 26, 2020

This PR adds support for a --load-system-env flag. This works similar to the existing
--load-local-env variable on the start command but is required to be used in tandem with the --env
flag and will use the file specified in --env as a filter. Only empty values in the env file will be
populated by the system env variables. This PR doesn't add that behavior to the "start" command as
this would be a breaking change that will be introduced in a separate version.

fix #144

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel force-pushed the dkundel/deploy-with-local-env branch from a4b8601 to f23f077 Compare June 29, 2020 18:31
This PR adds support for a --load-system-env flag. This works similar to the existing
--load-local-env variable on the start command but is required to be used in tandem with the --env
flag and will use the file specified in --env as a filter. Only empty values in the env file will be
populated by the system env variables. This PR doesn't add that behavior to the "start" command as
this would be a breaking change that will be introduced in a separate version.

fix #144
@dkundel dkundel force-pushed the dkundel/deploy-with-local-env branch from f23f077 to ee2e627 Compare June 29, 2020 19:48
@dkundel dkundel requested a review from philnash July 1, 2020 20:39
Copy link
Contributor

@philnash philnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 👍

@dkundel dkundel merged commit 7411e33 into master Jul 6, 2020
@dkundel dkundel deleted the dkundel/deploy-with-local-env branch July 6, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve deploying env variables safely
2 participants