Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I constantly get caught by commitlint, mostly for using 73 characters these days, though it used to be for more reasons. I thought that maybe I could re-arrange the order in which the hooks ran in order to fail commitlint before running the entire test suite.
Then I looked at husky and it was at version 3 in this project compared to the latest available version 7.0.1. So, I decided to upgrade while looking into hook order.
This PR just upgrades husky.
Along the way I came to understand the git hook order.
pre-commit
runs, thenprepare-commit-msg
, thencommit-msg
.The only way to have commitlint run before linting and test suite would be to run everything in the
commit-msg
hook. I've not implemented that yet as I wanted it to be a point of discussion. I opened #308 for this question.Meanwhile, this should bring husky up to date successfully!
Contributing to Twilio