Skip to content

chore: upgrades husky #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

chore: upgrades husky #309

merged 1 commit into from
Jul 13, 2021

Conversation

philnash
Copy link
Contributor

I constantly get caught by commitlint, mostly for using 73 characters these days, though it used to be for more reasons. I thought that maybe I could re-arrange the order in which the hooks ran in order to fail commitlint before running the entire test suite.

Then I looked at husky and it was at version 3 in this project compared to the latest available version 7.0.1. So, I decided to upgrade while looking into hook order.

This PR just upgrades husky.

Along the way I came to understand the git hook order. pre-commit runs, then prepare-commit-msg, then commit-msg.

The only way to have commitlint run before linting and test suite would be to run everything in the commit-msg hook. I've not implemented that yet as I wanted it to be a point of discussion. I opened #308 for this question.

Meanwhile, this should bring husky up to date successfully!

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel July 12, 2021 06:45
@dkundel dkundel merged commit 7a086a6 into main Jul 13, 2021
@dkundel dkundel deleted the upgrade-husky branch July 13, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants