Skip to content

build: adjust dependency imports for successful build #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

dkundel
Copy link
Contributor

@dkundel dkundel commented Jul 13, 2021

This fixes two issues currently breaking the build:

  1. for runtime-handler I had to adjust the type signature to use the new object that contains {request: {cookies: {}, headers: {}}
  2. for twilio-run I had to pin serverless-runtime-types to an older version for lerna not to symlink it as twilio-run itself won't support the new types anymore. For this one I opened Change twilio-run dependency version of serverless-runtime-types #313 to revert the change.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel changed the title feat(runtime-handler): handle incoming headers and cookies (#293) build: adjust dependency imports for successful build Jul 14, 2021
@dkundel dkundel merged commit c8eddae into features/handler-1.2.0 Jul 14, 2021
@dkundel dkundel deleted the dkundel/fix-handler-build branch July 14, 2021 01:10
dkundel added a commit that referenced this pull request Oct 14, 2021
* feat(runtime-handler): handle incoming headers and cookies (#293)

* feat(handler): update header and cookie support for Response (#296)

* feat(runtime-types): add cookie/header support for types (#297)

* build: adjust dependency imports for successful build (#314)

* chore(runtime-handler): add artifical rc-version bump

* chore(release): publish %s

 - [email protected]
 - @twilio-labs/[email protected]
 - @twilio/[email protected]
 - @twilio-labs/[email protected]
 - [email protected]

* fix(runtime-handler): using set-cookie now sets cookie header (#332)

* chore(release): publish %s

 - @twilio/[email protected]

* chore(release): publish %s

 - @twilio/[email protected]

* Update package.json

* Update package.json

Co-authored-by: Phil Nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants