feat(create-twilio-function): add deployinfo file to gitignore #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds .twiliodeployinfo to the default .gitignore fix #318
Within the createGitignore function we use fs.promises and also createWriteStream and the two aren't particularly compatible. createWriteStream far prefers callbacks and events. This PR rewrites createGitignore to use callbacks and streams internally returning a Promise for external users. This also adds the .twiliodeployinfo line to the top of the gitignore file rather than the bottom. This avoids having to open the file twice (gitignore.writeFile will end the write stream when it pipes all the content to it). I think this is the best place to put the addition as it will be where a reader starts looking when they open the gitignore file too.
philnash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
.twiliodeployinfoto the default.gitignore. It also refactorscreateGitignoreto fully use streams and callbacks internally, but still return a Promise. More detail on the refactor in the commit message for 6b4ce35.Fixes #318 and supersedes #319.
Contributing to Twilio