Skip to content

fix(create-twilio-function): handle rimraf failing #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

philnash
Copy link
Contributor

Received a report that creating a new project had failed for a developer
and then the cleanup task didn't end. There was an issue with deleting
the files that had been created which threw an unhandled error in the
cleanUpAndExit function leading to the spinner never stopping.

This adds a try/catch/finally around rimraf in cleanUpAndExit to ensure
that it does indeed exit.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Received a report that creating a new project had failed for a developer
and then the cleanup task didn't end. There was an issue with deleting
the files that had been created which threw an unhandled error in the
cleanUpAndExit function leading to the spinner never stopping.

This adds a try/catch/finally around rimraf in cleanUpAndExit to ensure
that it does indeed exit.
@philnash philnash requested a review from dkundel June 15, 2022 06:54
@dkundel dkundel merged commit b15a1cb into main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants