fix(create-twilio-function): handle rimraf failing #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received a report that creating a new project had failed for a developer
and then the cleanup task didn't end. There was an issue with deleting
the files that had been created which threw an unhandled error in the
cleanUpAndExit
function leading to the spinner never stopping.This adds a
try
/catch
/finally
aroundrimraf
incleanUpAndExit
to ensurethat it does indeed exit.
Contributing to Twilio