Skip to content

feat(templates): add support for custom template URLs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

dkundel
Copy link
Contributor

@dkundel dkundel commented Mar 13, 2020

This fixes #113. I added some basic tests for now. I'll add some additional tests before merging but I'd love your eyes at this @philnash

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel requested a review from philnash March 13, 2020 02:55
Copy link
Contributor

@philnash philnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing I can think of is handling the case where a user supplies a branch or repo that doesn't exist or isn't accessible (private repo issues?).

@dkundel
Copy link
Contributor Author

dkundel commented Mar 18, 2020

I think for now we'll just do the normal error handling here. I'll file an issue for improved error handling though

@dkundel dkundel force-pushed the dkundel/add-custom-template-url branch from b8523f5 to ade2fce Compare March 18, 2020 01:39
@philnash
Copy link
Contributor

Sounds good. Let's get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to change the location of function templates
2 participants