Skip to content

chore: Added tests and sonarcloud scan while adding the PR's #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2021
Merged

chore: Added tests and sonarcloud scan while adding the PR's #169

merged 4 commits into from
Oct 22, 2021

Conversation

ravali-rimmalapudi
Copy link
Contributor

Fixes

Closes: DII-149

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sr010
sr010 reviewed Oct 21, 2021
View reviewed changes
.github/workflows/cli-core-test.yml
@@ -0,0 +1,55 @@
name: Cli Core Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Can you format the PR title to the required format? It throws up everytime I run something on Librarian. You'll have to mention if it's a fix or feature or whatever is suitable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@onuzbee onuzbee changed the title Added tests and sonarcloud scan while adding the PR's chore: Added tests and sonarcloud scan while adding the PR's Oct 21, 2021
onuzbee
onuzbee approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@onuzbee onuzbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ravali-rimmalapudi ravali-rimmalapudi merged commit a26d6ee into main Oct 22, 2021
@ravali-rimmalapudi ravali-rimmalapudi deleted the pr_builds branch October 22, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sr010 sr010 sr010 left review comments

@kridai kridai kridai approved these changes

@onuzbee onuzbee onuzbee approved these changes

@shrutiburman shrutiburman shrutiburman approved these changes

@Sindhura3 Sindhura3 Awaiting requested review from Sindhura3

@charan678 charan678 Awaiting requested review from charan678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ravali-rimmalapudi @kridai @onuzbee @shrutiburman @sr010