Skip to content

fix: Fixing ocktokit api calls #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2022
Merged

fix: Fixing ocktokit api calls #211

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e45d898
Update update-release.js
sr010 Aug 2, 2022
0565942
Update update-release.js
kridai Aug 3, 2022
80cab32
Update update-release.js
kridai Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/scripts/update-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,26 @@
const core = require('@actions/core');
const { GitHub } = require('@actions/github');
const { Octokit } = require("@octokit/core");

/**
* Functionality from tubone24/update_release.
* Link: https://github.com/tubone24/update_release
*/
const updateRelease = async () => {
try {
const github = new GitHub(process.env.REPO_ACCESS_TOKEN);
const octokit = new Octokit({
auth: process.env.REPO_ACCESS_TOKEN
})
const [owner, repo] = process.env.REPO_NAME ? process.env.REPO_NAME.split('/') : [null, null];
const tag = process.env.TAG_NAME;
const getReleaseResponse = await github.repos.getReleaseByTag({

//https://docs.github.com/en/rest/releases/releases#get-a-release-by-tag-name
const getReleaseResponse = await octokit.request('GET /repos/{owner}/{repo}/releases/tags/{tag}',{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use the helper method mentioned here https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/docs/repos/getReleaseByTag.md instead of calling the api directly.

owner,
repo,
tag,
});


const {
data: {
id: oldReleaseId,
Expand Down Expand Up @@ -49,7 +54,8 @@ const updateRelease = async () => {
prerelease = oldPrerelease;
}

await github.repos.updateRelease({
//https://docs.github.com/en/rest/releases/releases#update-a-release
await octokit.request('PATCH /repos/{owner}/{repo}/releases/{release_id}', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly see https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/docs/repos/updateRelease.md.

owner,
release_id: oldReleaseId,
repo,
Expand Down