fix: pagination bug and drop page limit and page limit calculation #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en listing resources
spec/unit/base/Version.spec.js
Outdated
| @@ -29,3 +32,30 @@ describe('fetch method', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Paging limit', function () { | |||
There was a problem hiding this comment.
We may want to have similar tests as these other fixes:
https://github.com/twilio/twilio-ruby/pull/530/files
twilio/twilio-python#523
https://github.com/twilio/twilio-php/pull/654/files
There was a problem hiding this comment.
Thanks for the examples Elmer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
DI-1070: https://issues.corp.twilio.com/browse/DI-1070
Checklist
Related Pull Requests
https://code.hq.twilio.com/twilio/yoyodyne/pull/499