Skip to content

fix: handle building the HTTP client proxy URI without authentication #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2019
Merged

fix: handle building the HTTP client proxy URI without authentication #445

merged 3 commits into from
Nov 18, 2019

Conversation

laka3000
Copy link
Contributor

Related to #435

  • [✓] Run make test and ensure it passes locally
  • [✓] Run make lint to appease Rubocop

@laka3000 laka3000 mentioned this pull request Mar 15, 2019
Closed
@childish-sambino
Copy link
Contributor

@laka3000 Merged your changes with the proxy_prot changes that were added recently. Let me know if this works for you.

@childish-sambino childish-sambino added difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Sep 12, 2019
@childish-sambino childish-sambino changed the title Fix http client proxy URI without authentication fix: handle building the HTTP client proxy URI without authentication Nov 18, 2019
@childish-sambino childish-sambino merged commit 6d089e4 into twilio:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laka3000 @childish-sambino