breaking: Catch and wrap Faraday client errors #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
What do you think about adding a TROUBLESHOOTING.md that demonstrates this functionality? Something like what we do here.
bf4
reviewed
Sep 13, 2019
childish-sambino
changed the title
|
@thinkingserious Docs updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
Please ensure the following steps have been run before submitting this pull request:
make testand ensure it passes locallymake lintto appease Rubocop