Skip to content

chore: upgrade rubocop to 0.79.0 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ AllCops:
- 'lib/twilio-ruby/util/configuration.rb'
- 'vendor/**/*'

Metrics/LineLength:
Layout/LineLength:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max: 120
Exclude:
- 'spec/**/*'
Expand Down
7 changes: 4 additions & 3 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-12-18 11:23:55 -0600 using RuboCop version 0.77.0.
# on 2020-01-06 13:56:04 -0300 using RuboCop version 0.79.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -16,7 +16,7 @@ Gemspec/OrderedDependencies:

# Offense count: 1
# Configuration parameters: Include.
# Include: **/*.gemspec,
# Include: **/*.gemspec
Gemspec/RequiredRubyVersion:
Exclude:
- 'twilio-ruby.gemspec'
Expand All @@ -37,7 +37,8 @@ Layout/ExtraSpacing:

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
# SupportedStylesForExponentOperator: space, no_space
Layout/SpaceAroundOperators:
Exclude:
- 'spec/jwt/client_capability_spec.rb'
Expand Down
10 changes: 5 additions & 5 deletions lib/twilio-ruby.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@
require 'twilio-ruby/twiml/messaging_response'
require 'twilio-ruby/twiml/voice_response'

Dir[File.dirname(__FILE__) + '/twilio-ruby/http/**/*.rb'].each do |file|
Dir[File.dirname(__FILE__) + '/twilio-ruby/http/**/*.rb'].sort.each do |file|
require file
end
Dir[File.dirname(__FILE__) + '/twilio-ruby/framework/**/*.rb'].each do |file|
Dir[File.dirname(__FILE__) + '/twilio-ruby/framework/**/*.rb'].sort.each do |file|
require file
end
Dir[File.dirname(__FILE__) + '/twilio-ruby/rest/*.rb'].each do |file|
Dir[File.dirname(__FILE__) + '/twilio-ruby/rest/*.rb'].sort.each do |file|
require file
end
Dir[File.dirname(__FILE__) + '/twilio-ruby/rest/**/*.rb'].each do |file|
Dir[File.dirname(__FILE__) + '/twilio-ruby/rest/**/*.rb'].sort.each do |file|
require file
end
Dir[File.dirname(__FILE__) + '/twilio-ruby/compatibility/**/*.rb'].each do |file|
Dir[File.dirname(__FILE__) + '/twilio-ruby/compatibility/**/*.rb'].sort.each do |file|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require file
end

Expand Down
2 changes: 1 addition & 1 deletion twilio-ruby.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ Gem::Specification.new do |spec|
spec.add_dependency('rubysl') if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'rbx'

spec.add_development_dependency 'bundler', '>= 1.5', '< 3.0'
spec.add_development_dependency 'rubocop', '~> 0.77.0'
spec.add_development_dependency 'rubocop', '~> 0.79.0'
spec.add_development_dependency 'yard', '~> 0.9.9'
end