feat: Add Twilio::HTTP::Client#configure_connection
#559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwinShopify
force-pushed
the
enable-connection-configuration-blocks
branch
from
c976151 to
d1fa5b8
Compare
JenniferMah
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Thanks for your contribution @darwinShopify! Could you rebase your branch with the latest updates from main so we can get this change merged in?
Faraday recommends that adapters be the last configuration to be set. https://lostisland.github.io/faraday/middleware/#how-it-works Co-authored-by: Darwin Carrillo <[email protected]> Co-authored-by: Adam Archibald <[email protected]> Co-authored-by: Sam Bostock <[email protected]>
This allows consumers to configure things such as middlewares. Co-authored-by: Darwin Carrillo <[email protected]> Co-authored-by: Adam Archibald <[email protected]> Co-authored-by: Sam Bostock <[email protected]>
Update the README to include an example on how to use the configure_connection method. Co-authored-by: Sam Bostock <[email protected]> Co-authored-by: Darwin Carrillo <[email protected]> Co-authored-by: Adam Archibald <[email protected]>
darwinShopify
force-pushed
the
enable-connection-configuration-blocks
branch
from
d1fa5b8 to
58a3a96
Compare
|
@JenniferMah updated and ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
configure_connectionmethod to theTwilio::HTTP::Clientclass to allow consumers to apply custom configuration to the Faraday connection.The motivation for this change is to allow consumers to register custom middleware.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.