chore: Add sonarcloud analysis #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrimmingDev
force-pushed
the
add-sonarcloud-analysis
branch
2 times, most recently
from
db6726a to
6670b08
Compare
BrimmingDev
force-pushed
the
add-sonarcloud-analysis
branch
2 times, most recently
from
f31365a to
06bb925
Compare
beebzz
reviewed
Jan 18, 2022
| sed -i 's@'$GITHUB_WORKSPACE'@/github/workspace/@g' coverage.json | ||
| - name: SonarCloud Scan | ||
| if: ${{ (github.event_name == 'pull_request' || github.ref_type == 'branch') && matrix.ruby == '3.0' && !github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
This should be running SonarCloud on Ruby 3.0, but it looks like it's being skipped on that version too: https://github.com/twilio/twilio-ruby/runs/4859609125?check_suite_focus=true
There was a problem hiding this comment.
It skipped it because the source branch is from my fork otherwise it would blow up because of invalid tokens. You can see a valid run on my fork: https://github.com/BrimmingDev/twilio-ruby/actions/runs/1714902065.
beebzz
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sonarcloud analysis to the build
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.