Skip to content

fix: move require into TwilioWebhookAuthentication initialize (Fixes twilio/twilio-ruby#592) #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

engshien
Copy link

@engshien engshien commented Feb 8, 2022

Fixes

Fixes #592

I have moved the require into the initialize so it is only executed if the user needs the functionality. This is an alternative fix to just requiring the rack gem in the gemspec.

I have run the existing tests and my own tests that were failing in 5.63.1 due to the issue.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@engshien engshien changed the title fix: fix "cannot load such file -- rack/media_type" (Fixes twilio/twilio-ruby#592) fix: move require into TwilioWebhookAuthentication initialize (Fixes twilio/twilio-ruby#592) Feb 8, 2022
@philnash
Copy link
Contributor

Thank you for your contribution! Since this middleware is only important when rack is part of the application we've changed this in #602 so that if Rack is not present, the middleware doesn't get loaded. Version 5.65.1 was just released with this update, so you can now install the latest version and it will work again.

@philnash philnash closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"cannot load such file -- rack/media_type" on twilio-ruby v5.63.1
2 participants