fix: move require into TwilioWebhookAuthentication initialize (Fixes twilio/twilio-ruby#592) #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #592
I have moved the
require
into theinitialize
so it is only executed if the user needs the functionality. This is an alternative fix to just requiring the rack gem in the gemspec.I have run the existing tests and my own tests that were failing in 5.63.1 due to the issue.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.