Skip to content

chore: Accommodate jwt's minor and patch updates #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Jan 18, 2023

Current specification in gemspec pins the jwt version to the latest released one, consequently setting an obstacle where users have to wait until twilio-ruby modifies gemspec and releases it in order to update jwt.

Although I truly appreciate that you are constantly updating this library, I think it would be better if it accommodates updating jwt independent of twilio-ruby.

Also this change will

As a reference which might help, oauth2 gem relies on jwt in this manner: https://rubygems.org/gems/oauth2

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@shrutiburman
Copy link
Contributor

Thanks for the PR! We've added the review to our backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.

@shrutiburman shrutiburman added dependencies pull requests that update a dependency file type: twilio enhancement feature request on Twilio's roadmap labels Jan 19, 2023
@woodhull
Copy link

woodhull commented Feb 3, 2023

@shrutiburman I took a look and the diff in the jwt gem and it seems unlikely that loosening the dependency will cause any issues -- but it is blocking our use of the jwt gem version we'd like to use.

@alex-damian-negru alex-damian-negru mentioned this pull request Feb 3, 2023
8 tasks
@alex-damian-negru
Copy link

Also closes #633; noticed the PR after creating the issue 👀

@franzliedke
Copy link

Thanks! This would be great! 🙏🏼

We're looking forward to this change, as Dependabot is currently asking us to downgrade twilio-ruby by two major releases, just to let us upgrade the jwt gem.

@sealabcore
Copy link

🚀

@childish-sambino childish-sambino merged commit 616a522 into twilio:main Mar 15, 2023
@sato11 sato11 deleted the accommodate-jwt-minor-and-patch-updates branch March 23, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants