Skip to content

fix: match only against the end of a file path. #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

pat
Copy link
Contributor

@pat pat commented May 5, 2023

Otherwise if there happens to be .rb in a directory name, that'll be incorrectly modified as well.

I haven't added a test as this code is part of loading everything, rather than something that occurs once the library is loaded.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Otherwise if there happens to be .rb in a directory name, that'll be
incorrectly modified as well.
@broksonic21
Copy link

thanks for this one - we ran into it too (see #655 )

@shrutiburman shrutiburman self-assigned this May 8, 2023
@shrutiburman shrutiburman added the status: ready for merge code deemed fit for merge label May 8, 2023
@shrutiburman shrutiburman self-requested a review May 8, 2023 04:56
@shrutiburman shrutiburman merged commit 57d1d50 into twilio:main May 8, 2023
@jcavena
Copy link

jcavena commented May 23, 2023

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready for merge code deemed fit for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants