fix: fix the headers issue #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kridai merged 3 commits into main from fix-headers

Aug 8, 2023

Contributor

kridai commented Aug 8, 2023

Closes issue #669

Fixes

Fix the headers funtionality

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.


          fix: fix the headers issue

0a306ef

sbansla approved these changes

View reviewed changes

Contributor

sbansla left a comment

changes looks good to me.
Before: If header was set from any service, it was not going to server.
After: Issue fixed.

kridai added 2 commits

August 8, 2023 11:45


          chore: fix linting

420ce18


          chore: fix lint

5af212e

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

kridai merged commit 9bd7e72 into main

kridai deleted the fix-headers branch

August 8, 2023 06:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet