handling and returning valid error code for context.Canceled and cont… #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext.DeadlineExceeded error
marioizquierdo
approved these changes
Mar 11, 2021
rhysh
suggested changes
Mar 11, 2021
There was a problem hiding this comment.
The behavior change LGTM, but the tests are too far removed from how Twirp gets used in production. The tests should verify that we get the right behavior higher up in the stack, and demonstrate to readers (including our future selves) what that high-level behavior is.
added 5 commits
March 11, 2021 23:36
…exceed error checking outside body read error
… inside read body call fail
rhysh
suggested changes
Mar 16, 2021
added 5 commits
March 16, 2021 17:30
chetanvalagit
commented
Mar 17, 2021
marioizquierdo
suggested changes
Mar 24, 2021
rhysh
reviewed
Mar 25, 2021
rhysh
reviewed
Mar 25, 2021
rhysh
reviewed
Mar 25, 2021
rhysh
reviewed
Mar 25, 2021
rhysh
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ext.DeadlineExceeded error
*Issue #, if available: #293
Description of changes:
Proper error code return in case of context.Canceled (Error code will be returned twirp.Canceled) and context.DeadlineExceeded (Error code will be returned twirp. DeadlineExceeded), instead of 5xx 'Unexpected EOF'
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.