Update project #210
Merged
Update project #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
reviewed
May 15, 2018
| 'index.js', | ||
| 'testem.js', | ||
| 'ember-cli-build.js', | ||
| 'blueprints/*/index.js', |
There was a problem hiding this comment.
maybe change this to "blueprings/**/*.js"?
Then we don't need /* eslint-env node */ in the other node files inside the "blueprints/" dir.
There was a problem hiding this comment.
The tricky bit with those directories is that they're a mix of node and Emberland files. This entry is from the default addon blueprint, and our -addon-import and test-framework-detector are sort of oddballs, so it seemed simpler to leave it as-is rather than having to keep dealing with merge conflicts each time we update.
|
@chriskrycho @dwickern @jamescdavis any objections to this? It's the first in a chain that looks something like:
|
|
I'm 👍 on it; sorry, I meant to say as much a week ago! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
ember-cli-updates the project to Ember + CLI ~3.1.0 as a preliminary step toward reworking our test matrix as discussed in #190