Disable mypy ignore_missing_imports option

[sudosubin]

I have made things!

Enabled mypy ignore_missing_imports option, and updated test_import_all.yml.

• Remove removed module imports.
• Ignored mypy error report from psycopg2.extras, redis.*, and xml.sax.expatreader

[intgr]

Why is it not an error if non-existing modules are in this test? Can we enable some mypy option here to discover more such examples?

[flaeppe]

I think it's due to having ignore_missing_imports = true in the conf

django-stubs/mypy.ini

Line 6 in c25653e

ignore_missing_imports = true

[flaeppe]

Could we just add the following to the import_all_modules test case?

   case: import_all_modules
+    mypy_config: |
+        [mypy]
+        ignore_missing_imports = false

[sudosubin]

There were some errors caused by psycopg2.extras, redis.*, and xml.sax.expatreader, so I excluded it from the error report.

[intgr]

The test suite isn't happy about this change. We could disable ignore_missing_imports globally, there aren't that many suppressions we need to add.

But this quickly ballooned into a bigger project. I'm OK with reducing the scope of this, if you don't feel like you want to solve all that @sudosubin.

[intgr]

Cool, looks like this already found some bugs.

[flaeppe]

I agree with that we probably should enable ignore_missing_imports globally, better to be strict and relax when necessary. No need to do it all in the same place or at once though, as previously mentioned

[sudosubin]

I agree with that we probably should enable ignore_missing_imports globally, better to be strict and relax when necessary. No need to do it all in the same place or at once though, as previously mentioned

It looks like disable ignore_missing_imports makes errors like below.

It cannot be suppressed by mypy.ini's [mypy-django.contrib.gis.*] ignore_missing_imports = true settings, sadly 😢

It looks like installing the gdal package in the CI environment will fix this issue, but I'm not sure if that's a good idea. (Should it also be added to the requirements.txt?)

This issue was discovered while I was working on the 5.0 issue resolution, and I'd be happy to take it slow or have other maintainers do it. :)

The above issue was a problem in my local environment. When I cleared the cache and ran it inside a debian container, there were no problem. Sorry :)

[sudosubin]

django-stubs/utils/timezone.pyi:6: error: Cannot find implementation or library stub for module named "zoneinfo"  [import-not-found]
django-stubs/utils/timezone.pyi:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

Django 5.0 supports Python 3.10, 3.11, and 3.12, and the type error raised from 3.8 matrix. (which does not have zoneinfo builtin module yet.)

Does anyone have any ideas to solve this problem? (Remove 3.8, 3.9 support, or add # type: ignore comment to the zoneinfo import)

[intgr]

Django 5.0 supports Python 3.10, 3.11, and 3.12, and the type error raised from 3.8 matrix. (which does not have zoneinfo builtin module yet.)

Suppressing sounds fine to me. Or maybe a try / except ImportError, though not sure if that avoids the import-not-found error.

[sudosubin]

Thanks! I hope my commit 8e00810 solve the error :D

[andersk]

The PR should be retitled from “Enable …” to “Disable …”, as the value is being changed from true to false.

[sudosubin]

The PR should be retitled from “Enable …” to “Disable …”, as the value is being changed from true to false.

Oh, that's right. I updated the PR's title. Thanks :)

[flaeppe]

Thank you for this