You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve GenericAPIView.serializer_class classvar type generics (#672)
The type for the attribute does not match what the `get_serializer_class` function returns.
Thus, modifying it to match so it is `type[BaseSerializer[_MT_co]]`
Unfortunately this doesn't solve the issue of projects programmatically returning different serializers in `get_serializer_class` such that one option would be: `return self.serializer_class` such that it would be technically incompatible with the typing. But that seems outside the scope of this change and there are other ways to accomplish it (e.g. holding known serializer classes in a `dict` on the class as an attribute).
0 commit comments