Improve GenericAPIView.serializer_class classvar type generics
#672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type for the attribute does not match what the `get_serializer_class` function returns. Thus, modifying it to match so it is `type[BaseSerializer[_MT_co]]` Unfortunately this doesn't solve the issue of projects programmatically returning different serializers in `get_serializer_class` such that one option would be: `return self.serializer_class` such that it would be technically incompatible with the typing. But that seems outside the scope of this change and there are other ways to accomplish it (e.g. holding known serializer classes in a `dict` on the class as an attribute).
sobolevn
approved these changes
Sep 27, 2024
intgr
changed the title
GenericAPIView.serializer_class classvar type generics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
The type for the attribute does not match what the
get_serializer_classfunction returns.Thus, modifying it to match so that the truthy type of it is
type[BaseSerializer[_MT_co]]Unfortunately this doesn't solve the issue of projects programmatically returning different serializers in
get_serializer_classsuch that one option would be:return self.serializer_classsuch that it would be technically incompatible with the typing. But that seems outside the scope of this change and there are other ways to accomplish it (e.g. holding known serializer classes in adicton the class as an attribute).Related issues