Add APIClient type to test cases #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment on this? |
|
@MarcinWieczorek can you please trigger the build once again? CI is failing for some reason right now. |
|
How? CI doesn't even recognize the project now, I guess it won't be any better. |
|
@mkurnikov we need your help with the CI 🙂 |
|
It's the README that is wrong, it points to |
|
@MarcinWieczorek sure |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_classis explicitly set toAPIClientinrest_framework/test.py, but I suppose that the client is created dynamically, thus drf-stubs have no idea that it should be anAPIClientand not aClientwarning me aboutresponse.dataandclient.force_authenticate.