Changed from list to abstract Sequence type for http verbs #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows method decorator to not fail on tuple, as there is no reason to have `methods` mutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows method decorator to not fail on tuple, as there is no reason to have
methodsmutableI have made things!
Changed from
listto abstractSequencetype for http verbs. while documentation useslistfor declaring methods for action decorator, the actual implementation only uses fact that methods areIterable, and they rebuild this list all over again for normalisation.Documentation: https://www.django-rest-framework.org/api-guide/viewsets/#viewset-actions