Allow None
for HyperlinkedRelatedField.get_url(format=)
parameter
#485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Hi! I ran into a false positive when running mypy in combination with this package.
Actually the
format
parameter can also beNone
in theget_url()
method, it is passed toreverse()
where the default value also isNone
. We've been using it like this in our application for a long time and it works fine like that.Please see:
https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/relations.py#L326
https://github.com/encode/django-rest-framework/blob/3.14.0/rest_framework/reverse.py#L32
Thanks in advance for your time and consideration.
Related issues
I didn't create an issue, should I?