More precise *Field arguments and instance attributes #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Jan 29, 2020
intgr
force-pushed
the
more-precise-field-args-and-attrs
branch
from
d8929f7 to
a7a1cd4
Compare
|
Pushed a small update, I found that |
intgr
force-pushed
the
more-precise-field-args-and-attrs
branch
from
a7a1cd4 to
1a7ba2b
Compare
sobolevn
reviewed
Jan 30, 2020
Field constructors are quite inconsistent in Django REST Framework: some take position arguments, some don't. Some pass positional arguments to their parent class, others pass only keyword arguments. It took a while but I sorted through all the constructors and nailed down the precise behavior. The stubs did not previously denote keyword-only arguments, and the order of positional arguments was slightly wrong in many places. Also, added many instance attributes of *Field classes that were missing.
intgr
force-pushed
the
more-precise-field-args-and-attrs
branch
from
1a7ba2b to
9305a50
Compare
sobolevn
approved these changes
Jan 30, 2020
|
Thanks! |
|
Thanks too, working on TypedDjango projects has been pleasant. :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field constructors are quite inconsistent in Django REST Framework: some take position arguments, some don't. Some pass positional arguments to their parent class, others pass only keyword arguments. It took a while but I sorted through all the constructors and nailed down the precise behavior.
The stubs did not previously denote keyword-only arguments, and the order of positional arguments was slightly wrong in many places.
Also, added many instance attributes of *Field classes that were missing.