Skip to content

Cannot be used on Windows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
selimb opened this issue Dec 10, 2019 · 2 comments
Closed

Cannot be used on Windows #13

selimb opened this issue Dec 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@selimb
Copy link
Contributor

selimb commented Dec 10, 2019

capturer, a dependency of this project, cannot be used on Windows, as it clearly states in the first paragraph of the documentation.

Is capturer a hard requirement? As far as I can tell, it's only used in typecheck_in_same_process to capture mypy's output. However:

  • Both mypy.main.process_options and mypy.build.build accept an optional TextIO for stdout and stderr.
  • contextlib.redirect_stdout and contextlib.redirect_stderr could be used here, since nothing runs in a subprocess (as far as I can tell? otherwise I don't see how mypy could even reliably support the parameters above)

I'd be happy to submit a PR, unless I've missed something.
@selimb selimb mentioned this issue Dec 10, 2019
Merged
1 task
@sobolevn
Copy link
Member

@selimb sure! Thanks a lot.

@sobolevn sobolevn added the enhancement New feature or request label Dec 10, 2019
@selimb selimb mentioned this issue Dec 10, 2019
Merged
@mkurnikov
Copy link
Member

Fixed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkurnikov @sobolevn @selimb