Make it work on Windows #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selimb
commented
Dec 10, 2019
| @@ -180,12 +189,10 @@ def typecheck_in_same_process(self, execution_path: Path, mypy_cmd_options: List | |||
| # add current directory to path | |||
| sys.path.insert(0, str(execution_path)) | |||
|
|
|||
| with capturer.CaptureOutput(merged=False) as captured_std_streams: | |||
| with capture_std_streams() as (stdout, stderr): | |||
There was a problem hiding this comment.
Just FYI, I believe I noticed typecheck_in_same_process isn't covered by the tests
sobolevn
reviewed
Dec 10, 2019
selimb
commented
Dec 12, 2019
pytest_mypy/tests/test-extension.yml
Outdated
| @@ -3,5 +3,5 @@ | |||
| # if hook works, main should contain 'reveal_type(1)' | |||
| reveal_type: 1 | |||
| out: | | |||
| main:1: note: Revealed type is 'builtins.int' | |||
| main:1: note: Revealed type is 'Literal[1]' | |||
There was a problem hiding this comment.
Mentioned it in the commit, but I needed to change this so that the tests would pass on the latest mypy version (0.750). Was failing on Travis as well: https://travis-ci.com/typeddjango/pytest-mypy-plugins/jobs/265800510
selimb
commented
Dec 12, 2019
| @@ -163,6 +167,9 @@ def typecheck_in_new_subprocess(self, execution_path: Path, mypy_cmd_options: Li | |||
|
|
|||
| # add current directory to path | |||
| self.environment_variables['PYTHONPATH'] = str(execution_path) | |||
| # Windows requires this to be set, otherwise the interpreter crashes | |||
| if 'SYSTEMROOT' in os.environ: | |||
| self.environment_variables['SYSTEMROOT'] = os.environ['SYSTEMROOT'] | |||
There was a problem hiding this comment.
FYI, just found out this is documented in subprocess.Popen
mkurnikov
approved these changes
Dec 12, 2019
sobolevn
approved these changes
Dec 12, 2019
|
@mkurnikov Welcome! Thanks for your work on this. |
griels
pushed a commit
to griels/pytest-mypy-plugins
that referenced
this pull request
Dec 19, 2024
* make it work on Windows. ditch capturer. * fix test for mypy==0.750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
capturerdependency: usecontextlib.redirect_*instead.Also fixed some other minor issues
See #13