Skip to content

Switched tsconfig.json back to module: commonjs #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 1, 2022

PR Checklist

Overview

Creates a composite tsconfig setup so that source files are built with "module": "commonjs" and tests are built with "module": "esnext". Added a nice little "noEmit": true for test files, too, since they don't need to be.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8aa036f into main Mar 1, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the commonjs-again branch March 1, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give up on outputting ESM modules
1 participant