Skip to content

feat(types): add strict parent types for function-declaration, default-export and named-export nodes #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(types): add strict parent types for function-declaration, default-export and named-export nodes #10685

merged 1 commit into from
Jan 28, 2025
+28 −0

Conversation

ronami
Copy link
Member

@ronami ronami commented Jan 19, 2025 •
edited
Loading

PR Checklist

Overview

This PR addresses #10682, follows #9560 up, and adds strict parent types for the proposed changes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b8f3b9e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/678d6f5cfd2d4300084f4590
😎 Deploy Preview https://deploy-preview-10685--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b8f3b9e.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-23 14:21:55 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 19, 2025

View your CI Pipeline Execution ↗ for commit b8f3b9e.

Command Status Duration Result
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-19 21:33:09 UTC

@ronami ronami marked this pull request as ready for review January 19, 2025 21:50
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

packages/types/src/ts-estree.ts
@@ -72,6 +72,34 @@ declare module './generated/ast-spec' {
| TSESTree.ImportDeclaration;
}

interface ExportDefaultDeclaration {
parent: TSESTree.BlockStatement | TSESTree.Program | TSESTree.TSModuleBlock;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSESTree.BlockStatement

TIL this does parse correctly despite the compiler complaint. Nifty.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 23, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit a0c30f2 into typescript-eslint:main Jan 28, 2025
68 checks passed
@ronami ronami deleted the add-strict-parent-types branch January 28, 2025 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: add strict parent types for nodes that have well-defined parents
2 participants
@ronami @JoshuaKGoldberg