-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): support type assertions in no-extra-parens rule #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 97.14% 97.14% +<.01%
==========================================
Files 73 74 +1
Lines 2868 2875 +7
Branches 473 473
==========================================
+ Hits 2786 2793 +7
Misses 49 49
Partials 33 33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of documentation - do we just want to link to the ESLint documentation instead of copying it over here?
I know we've copied it in the past, but maybe if we just document our changes to the base rule, and link out it'd be cleaner for us?
Thoughts @typescript-eslint/core-team ?
If yes - we should fix it across the board (in a separate PR).
If no then this PR LGTM (apart from the one minor nit).
Great work @webschik.
👍 Figured out all the pieces to extending a base rule without any documentation.
I’d say we should link to the original docs and describe how our rule differs. |
@bradzacher , @j-f1 , I can update disallow unnecessary parentheses (no-extra-parens)Rule DetailsThis rule extends the base eslint/no-extra-parens rule. How to use
Options |
@bradzacher , can we merge this PR? |
Sorry @webschik - it got lost in my notifications. |
Fixes #12