feat(parser): use monorepo typescript-estree #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(typescript-eslint-parser takes up too many characters of the commit length budget :D ) |
|
you should update visitorKeys |
|
nvm |
armano2
previously approved these changes
Jan 17, 2019
JamesHenry
force-pushed
the
connect-parser-and-ts-estree
branch
from
4c89c93 to
8966c29
Compare
|
:( not working on CI yet though... I can't reproduce locally, even with a fresh install. @armano2 Would you mind pulling the branch and trying on your machine? |
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
## 2.2.0 (2018-08-25) * ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6)) * ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7) * Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e)) * docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be)) * chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6)) * chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e)) * chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397)) * chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18) * chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20) * chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8) * chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11) * chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17) * chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa)) * chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12) * chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13) * chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9) * chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19) * chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10) * chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2)) * chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6) * refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629)) * style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756)) * feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
# [3.0.0](JamesHenry/eslint-plugin-tslint@v2.1.0...v3.0.0) (2018-09-09) ### Bug Fixes * Fixed bug when file not defined in tsconfig ([20b498b](JamesHenry/eslint-plugin-tslint@20b498b)) * Pass sourceText parameter to service getSource ([dd4c2f8](JamesHenry/eslint-plugin-tslint@dd4c2f8)) * Update program when sourceFile was updated ([0fe933c](JamesHenry/eslint-plugin-tslint@0fe933c)) * Updated typescript-service dependency ([2f4f434](JamesHenry/eslint-plugin-tslint@2f4f434)) ### Features * **core:** Added support rules requires type information ([6bc1deb](JamesHenry/eslint-plugin-tslint@6bc1deb)), closes [#32](JamesHenry/eslint-plugin-tslint#32) [#34](JamesHenry/eslint-plugin-tslint#34) * Post merge adapdation from tslint2 repository ([477c656](JamesHenry/eslint-plugin-tslint@477c656)), closes [#32](JamesHenry/eslint-plugin-tslint#32) [#34](JamesHenry/eslint-plugin-tslint#34) ### BREAKING CHANGES * New dependency
JamesHenry
force-pushed
the
connect-parser-and-ts-estree
branch
from
8966c29 to
69df3dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 11 11
Lines 1686 1686
Branches 376 376
=======================================
Hits 1581 1581
Misses 55 55
Partials 50 50Continue to review full report at Codecov.
|
|
@armano2 Was simple in the end - I just had to run build before the tests! I was thinking of lerna link too much like npm link. |
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
## 2.2.0 (2018-08-25) * ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6)) * ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7) * Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e)) * docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be)) * chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6)) * chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e)) * chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397)) * chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18) * chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20) * chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8) * chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11) * chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17) * chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa)) * chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12) * chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13) * chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9) * chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19) * chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10) * chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2)) * chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6) * refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629)) * style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756)) * feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
# [3.0.0](JamesHenry/eslint-plugin-tslint@v2.1.0...v3.0.0) (2018-09-09) ### Bug Fixes * Fixed bug when file not defined in tsconfig ([20b498b](JamesHenry/eslint-plugin-tslint@20b498b)) * Pass sourceText parameter to service getSource ([dd4c2f8](JamesHenry/eslint-plugin-tslint@dd4c2f8)) * Update program when sourceFile was updated ([0fe933c](JamesHenry/eslint-plugin-tslint@0fe933c)) * Updated typescript-service dependency ([2f4f434](JamesHenry/eslint-plugin-tslint@2f4f434)) ### Features * **core:** Added support rules requires type information ([6bc1deb](JamesHenry/eslint-plugin-tslint@6bc1deb)), closes [#32](JamesHenry/eslint-plugin-tslint#32) [#34](JamesHenry/eslint-plugin-tslint#34) * Post merge adapdation from tslint2 repository ([477c656](JamesHenry/eslint-plugin-tslint@477c656)), closes [#32](JamesHenry/eslint-plugin-tslint#32) [#34](JamesHenry/eslint-plugin-tslint#34) ### BREAKING CHANGES * New dependency
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
JamesHenry
pushed a commit
that referenced
this pull request
Jan 18, 2019
Luckeu
pushed a commit
to Luckeu/typescript-eslint
that referenced
this pull request
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of the "proper" monorepo!
I've verified this works with local rebuilds, make a change in typescript-estree, rebuild and it retriggers the test watcher of tyepscript-eslint-parser, for example.