Refactor verify_external_req for readability #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split individual checks into separate functions
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I'll be really occupied for the next 2 days. So it depends if I find the energy. But can review by the end of the week if no one beats me to it! |
Avasam
reviewed
Mar 1, 2025
There was a problem hiding this comment.
This is a nice split of a complicated function ! As far as I can tell, the logic should all be the same.
I also appreciate the name change to validate_pypi_response to make it less ambiguous.
I have 1 suggested improvement and 1 nitpick. Neither are blockers. Otherwise LGTM.
Co-authored-by: Avasam <[email protected]>
Avasam
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to review #159, I found the
verify_external_req()function very hard to understand and to follow its logic. It has multiple early exits, and understanding what the individual checks do (and where they end) is not trivial. In fact, I think a bug or two hides in the function.Therefore, this PR extracts the individual checks, and reorders the logic to prevent early exist to make it easier to follow.
@Avasam: Do you want to review this? After this is merged, you'd have to adapt #159, but I promise to review it promptly.