Skip to content

Reduce installation size #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 1, 2025
Merged

Reduce installation size #1

merged 13 commits into from
Mar 1, 2025

Conversation

SukkaW
Copy link

@SukkaW SukkaW commented Mar 22, 2024

Given that patch-package is no longer actively maintained, I thought it would be prudent to bring the proposal from ds300#499 to our attention.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bc89c87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@unts/patch-package Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JounQin JounQin force-pushed the reduce-installation-size-1 branch from a4d759f to 5ada466 Compare March 1, 2025 09:59
@socket-security Socket Security
Copy link

socket-security bot commented Mar 1, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

JounQin
JounQin approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice this for a long time.

@JounQin JounQin force-pushed the reduce-installation-size-1 branch from 2a85e6e to 679ce95 Compare March 1, 2025 11:11
@SukkaW
Copy link
Author

SukkaW commented Mar 1, 2025

@JounQin I myself have moved on to pnpm with its own built-in pnpm patch. But I can help improve @un-ts/patch-package even further.

@JounQin JounQin force-pushed the reduce-installation-size-1 branch from 214284b to 8f26944 Compare March 1, 2025 11:26
@JounQin
Copy link
Member

JounQin commented Mar 1, 2025

Thanks @SukkaW! Some regression tests are failing due to fs-extra replacing, I've just reverted them back in this PR. You can confirm by yarn jest regressionTests.

I'm still checking other errors.

@JounQin
Copy link
Member

JounQin commented Mar 1, 2025

alexeyraspopov/picocolors#79

picocolors doesn't work as expected on CI.

@JounQin JounQin force-pushed the reduce-installation-size-1 branch from 10a27a9 to 42793f8 Compare March 1, 2025 12:25
@JounQin JounQin force-pushed the reduce-installation-size-1 branch from f9a1b28 to bc89c87 Compare March 1, 2025 13:26
@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

@JounQin JounQin merged commit 71fcada into un-ts:fork-release Mar 1, 2025
7 checks passed
@JounQin JounQin mentioned this pull request Mar 1, 2025
Merged
@JounQin
Copy link
Member

JounQin commented Mar 1, 2025

Stay on chalk temporarily, let's move on in another breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JounQin JounQin JounQin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukkaW @JounQin