Adds storage of json data; expose default_branch #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyzmo
force-pushed
the
features/store_json_data
branch
2 times, most recently
from
1c7b4de to
94f9aaa
Compare
Signed-off-by: Guyzmo <[email protected]>
guyzmo
force-pushed
the
features/store_json_data
branch
from
94f9aaa to
6ae13ca
Compare
|
@guyzmo Thanks! @ethantkoenig will do a code review soon, in the meantime can you augment the tests to maintain or increase the test code coverage? |
|
I'm fine with that, let's stick with the other PR ☺ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entity.jsonwhereentityis anygogs_client.entity.*, so it's possible to introspect whethere there's any missing property to be exposed ;default_branchas entity to be exposed.